DM-29907: Update the idFactory for the deblender input catalog #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current gen3 pipeline does not update the catalog with the last source id in the mergeDet catalog, so if there were any merged peaks culled then the next source id starts too low, resulting in a catalog that is not sorted with some duplicate entries. This commit fixes that by notifying the idFactory of the largest source id.
TallJimbo
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current gen3 pipeline does not update the catalog with the
last source id in the mergeDet catalog, so if there were any
merged peaks culled then the next source id starts too low,
resulting in a catalog that is not sorted with some duplicate
entries.
This commit fixes that by notifying the idFactory of the largest
source id.