Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29344: Investigate the CI differences between Gen 2 and 3 in COSMOS field #508

Merged
merged 1 commit into from May 5, 2021
Merged

DM-29344: Investigate the CI differences between Gen 2 and 3 in COSMOS field #508

merged 1 commit into from May 5, 2021

Conversation

mrawls
Copy link
Contributor

@mrawls mrawls commented May 4, 2021

This PR makes doScaleDiffimVarianceTask True to be the new default behavior in imageDifferenceTask. We won't need to override this config in any pipeline or ap_verify-style dataset to get consistent results.

isullivan
isullivan approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change overlaps with DM-29869, but once you and @kherner decide which one should be merged, this is fine.

@mrawls mrawls merged commit 29b1506 into master May 5, 2021
@mrawls mrawls deleted the tickets/DM-29344 branch May 5, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrawls @isullivan