DM-27032: Create deblended source metric #512
Conversation
kfindeisen
force-pushed
the
tickets/DM-27032
branch
from
d6fdcb1
to
9183bd0
Compare
There was a problem hiding this comment.
This looks very good! Please ensure you've fully digested the Community post pertaining to how the children, parents, primary, inner regions, etc. are all related. In line with this, you might consider adding tests to check, e.g., if the number of one kind of source is less/greater than the number of a different kind of source.
doc/lsst.pipe.tasks/tasks/lsst.pipe.tasks.metrics.NumberDeblendChildSourcesMetricTask.rst
Show resolved
Hide resolved
| meas = result.measurement | ||
|
|
||
| self.assertEqual(meas.metric_name, self.METRIC_NAME) | ||
| assert_quantity_allclose(meas.quantity, u.Quantity(1)) |
There was a problem hiding this comment.
TIL about this handy assert_quantity_allclose. It feels a bit like overkill here where there aren't really quantities with units and values in the dummy catalog.
There was a problem hiding this comment.
Should I remove it? I think it was more a "better safe than sorry" thing...
There was a problem hiding this comment.
I don't think it hurts anything, I just spent some time trying to figure out where the quantities you were comparing were hiding, is all :) I like the idea that some day, our catalogs may indeed have such attributes.
There was a problem hiding this comment.
Sorry, I'm confused. I'm comparing the Quantity output by the metric task to a reference value; where do the input catalogs come in?
I thought your "overkill" comment was about not using exact equality for values that started life as integers...
There was a problem hiding this comment.
I wrote "catalogs" but really meant "thing the metric is computing" (which may or may not originate from a catalog, and may or may not have units attached to it). Sorry for the confusion.
kfindeisen
force-pushed
the
tickets/DM-27032
branch
from
9183bd0
to
ee5c645
Compare
kfindeisen
force-pushed
the
tickets/DM-27032
branch
from
ee5c645
to
5013283
Compare
These tasks could probably be factored further, since the only difference is in the criteria used for filtering sources, but handling columns in a general way would be nontrivial and should probably await the addition of more varied metrics.
kfindeisen
force-pushed
the
tickets/DM-27032
branch
from
5013283
to
7562649
Compare
This PR implements two new deblending-related metrics defined in lsst/verify_metrics#27.