DM-29869: Make doScaleDiffimVariance=True the default in ImageDifferenceTask #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
May 26, 2021
There was a problem hiding this comment.
These changes look self-consistent and OK. Please clean up the commit history, I think all this can be in just 1-2 commits, and I'm confused why you have some kind of merge commit. Keep these guidelines in mind https://developer.lsst.io/work/flow.html#appendix-commit-organization-best-practices
doSelectSources now defaults False, doDecorrelation now defaults True, and detection.thresholdValue now defaults to 5.0. Also move some other configs from setDefaults to the Task config definitions, and remove doDecorrelation, thresholdValue, doSelectSources, doScaleDiffimVariance from DRP.yaml since they are now in the task defaults.
mrawls
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move some task defaults from DRP.yaml to setDefaults in imageDifference.py. Should be quick.