DM-30149: Check if the TransformDiaSourceCatalog pipeline task can be used on DC2 data for use in DP0 #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
approved these changes
May 13, 2021
| connections.coaddName: goodSeeing | ||
| connections.diaSourceSchema: goodSeeingDiff_diaSrc_schema | ||
| connections.diaSourceCat: goodSeeingDiff_diaSrc | ||
| connections.diffIm: goodSeeingDiff_differenceExp |
There was a problem hiding this comment.
With your one additional contract, other than the template connections.coaddName: goodSeeing, the only connection that needs to be explicitly set here is connections.diffIm which is only to satisfy the contract checker. I filed DM-30210 for the contract-checker issue.
You could either:
- Add some more contracts:
imageDifference.connections.outputSchema == transformDiaSourceCat.connections.diaSourceSchema
imageDifference.connections.diaSources == transformDiaSourceCat.connections.diaSourceCat
which would require adding the explicit:
connections.outputSchema: goodSeeingDiff_diaSrc_schema
connections.diaSources: goodSeeingDiff_diaSrc
to the imageDifference section
or
2) remove these explicit connections
Modify pipeline import.
morriscb
force-pushed
the
tickets/DM-30149
branch
from
dd56119
to
78c6724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TransformDiaSourceCatalogTask to DRP pipeline.