DM-29627: Update config/column names for source injection #522
Conversation
| dtype=bool, | ||
| default=True, | ||
| default=False |
There was a problem hiding this comment.
Are you changing the default value here?
There was a problem hiding this comment.
No, I think github (or diff) just had a hard time figuring out which two lines to compare. The "before" side is for doCleanCat, which is still True, and the "after" side is for doSubSelectSources, which is still False.
| "half-light ellipse.", | ||
| dtype=str, | ||
| default="bulge_pa", | ||
| ) |
There was a problem hiding this comment.
North and East? Might be worth spelling that out.
| cfg.disk_axis_ratio_col: 'disk_axis_ratio', | ||
| }, | ||
| copy=False | ||
| ) |
There was a problem hiding this comment.
Is there anyway to make this syntax easier to read?
There was a problem hiding this comment.
Can you clarify? Which syntax could be improved?
There was a problem hiding this comment.
I find everything being on different lines very hard to follow. If other people find this spread out format easy to read though then stick with it.
There was a problem hiding this comment.
I think the indentation style is probably okay. (FWIW, black seems to mostly agree.)
But would more intermediate variables help maybe?
Let me know if you like this or something else better.
| and cfg.aBulge in fakeCat.columns | ||
| and cfg.bBulge in fakeCat.columns | ||
| ): | ||
| fakeCat['bulge_axis_ratio'] = \ |
There was a problem hiding this comment.
https://developer.lsst.io/python/style.html#python-s-implied-continuation-inside-parens-brackets-and-braces-should-be-used-for-wrapped-lines, backslashes for line continuation are not preferred.
jmeyers314
force-pushed
the
tickets/DM-29627
branch
from
04fcad0
to
542165a
Compare
jmeyers314
force-pushed
the
tickets/DM-29627
branch
from
542165a
to
af8acf3
Compare
No description provided.