tickets/DM-29728 Introduce configurable actions for DataFrames #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Jun 2, 2021
| @@ -0,0 +1,3 @@ | |||
| from ._actions import * | |||
| from ._baseDataFrameActions import DataFrameAction | |||
| from ._evalColumnExpression import * | |||
There was a problem hiding this comment.
Are these star imports legit?
There was a problem hiding this comment.
Yeah, this is pretty normal for a __init__ file, especially if the sub modules are "private"
sr525
reviewed
Jun 2, 2021
| with np.warnings.catch_warnings(): | ||
| np.warnings.filterwarnings('ignore', r'invalid value encountered') | ||
| np.warnings.filterwarnings('ignore', r'divide by zero') | ||
| return -2.5 * np.log10(df[self.column] / fluxMag0) |
There was a problem hiding this comment.
As the plotting code runs on the object tables do you think it is worth making MagColumn by default operate on nanojanskies? The plotting code is currently the main user of these functions but I don't know if it will be forever.
There was a problem hiding this comment.
I changed it to MagColumnDN to leave room for something from Janskeys or something
sr525
reviewed
Jun 2, 2021
sr525
reviewed
Jun 2, 2021
sr525
reviewed
Jun 2, 2021
python/lsst/pipe/tasks/dataFrameActions/_baseDataFrameActions.py
Outdated
Show resolved
Hide resolved
sr525
reviewed
Jun 2, 2021
| # look up to see if the value is in cache already | ||
| if result := self._actionCache.get(key): | ||
| print("returning cache") | ||
| return result |
There was a problem hiding this comment.
Should this print statement still be here?
This commit introduces a base class for configurable actions that works on Data Frames, basic concrete actions, and some supporting functions.
natelust
force-pushed
the
tickets/DM-29728
branch
from
04a8a6f
to
fd1f42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a base class for configurable actions that
works on Data Frames, basic concrete actions, and some supporting
functions.