Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30024: Implement matching in DRP DiaAssociation task #526

Merged
merged 4 commits into from
Jun 9, 2021
Merged

DM-30024: Implement matching in DRP DiaAssociation task #526

merged 4 commits into from
Jun 9, 2021
+709 −8

Commits on Jun 9, 2021

  1. Add utilities and simple_association task. 

    Finish docs and rename to camel case.
    @morriscb
    morriscb committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d559cc9 View commit details
    Browse the repository at this point in the history

  2. Add unittest. 

    Debug SimpleAssociationTask.

Debug add and update unittests.

Debug unittests.

Add run test.

switch variables to camel case.

Debug SimpleAssociationTask variable names.

Task worked with very little proding. I'm good at my job :)

Add full run test.

Debug simple association run test.
    @morriscb
    morriscb committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    7cdf8ae View commit details
    Browse the repository at this point in the history

  3. Hook up SimpleAssociation into DrpAssociationPipeline. 

    Debug pipeline and linting fixes.

Debug pipeline.

Confim outputs on ap_verify ci datasets.

Fixup docs.

Update docs on test_simpleAssociation.py

Add quick comment to associationUtils.py.

Fixup comments.
    @morriscb
    morriscb committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b926ef6 View commit details
    Browse the repository at this point in the history

  4. Respond to reviewers. 

    Add drpAssociation to diffImDRP subset.

Fix linting.

Fix white space around division.
    @morriscb
    morriscb committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    26f8951 View commit details
    Browse the repository at this point in the history