Add MakeCcdVisitTableTask to postprocess.py #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
requested changes
Jun 7, 2021
cmsaunders
force-pushed
the
tickets/DM-30192
branch
2 times, most recently
from
05d800d
to
7ae9a8d
Compare
erykoff
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Thank you, all the comments are addressed. I think we also should add this task to the pipeline and then it'll be automatically run, and tested with ci_hsc_gen3 (otherwise, this is not tested at all as far as I can tell.). If this is what we decide to do, you should add a comment that it is tested as part of ci_hsc_gen3.
cmsaunders
force-pushed
the
tickets/DM-30192
branch
from
7ae9a8d
to
47cd508
Compare
cmsaunders
force-pushed
the
tickets/DM-30192
branch
from
47cd508
to
6df6f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.