DM-30649: adapt to adjustQuantum API change and propagate NoWorkFound #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-30649
branch
from
2b45e64
to
95055c7
Compare
yalsayyad
approved these changes
Jun 16, 2021
AssembleCoadd raises NoWorkFound because it really had nothing to do. MakeWarp just writes nothing and ends successfully because it might write one kind of warp and not the other. This should remove the need for the doWriteEmptyWarps configuration option, but I haven't attempted to remove or deprecate it yet in order to avoid backwards compatibility headaches.
TallJimbo
force-pushed
the
tickets/DM-30649
branch
from
35a29c4
to
a04cea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.