DM-30673: Update docs and function names in associationUtils.py #532
Conversation
| Parameters | ||
| ---------- | ||
| nside : `int` | ||
| Resolution of healpixel "grid"> |
| nside : `int` | ||
| Resolution of healpixel "grid"> | ||
| index : `int` | ||
| Index of the healpix we want to find the location of. |
There was a problem hiding this comment.
"Index of the healpix pixel"...
| max_rad : `float` | ||
| Max distance in radians to search nearby healpixels. | ||
| min_rad : `float`, optional | ||
| Minimum distance to search healpixels. Default = 0. |
There was a problem hiding this comment.
"Minimum distance in radians"...
| return np.dstack([np.cos(dec*np.pi/180)*np.cos(ra*np.pi/180), | ||
| np.cos(dec*np.pi/180)*np.sin(ra*np.pi/180), | ||
| np.sin(dec*np.pi/180)])[0] |
| """Convert equatorial ra,dec in degrees to x,y,z on the unit sphere | ||
| parameters | ||
|
|
||
| Vetorized version of ``eq2xyz`` |
|
|
||
|
|
||
| def convert_spherical_array(array): | ||
| """Convert from ra,dec to spherical from array""" | ||
| """Convert from and a array ra,dec to spherical. |
There was a problem hiding this comment.
"Convert from an array of ra,dec to spherical"?
|
|
||
| Most other calculations are very simple and not worth testing. | ||
| """ | ||
| # Find nearest pixel to r=45, dec=45. |
There was a problem hiding this comment.
Please define the test RA and Dec as variables, and pass those to your functions. Also, please use different numbers for Ra and Dec, so that this test will catch if the order of parameters gets switched. Maybe raInit = 225 and decInit = 45, for example.
There was a problem hiding this comment.
Okay, this may lead to a change in the number of pixels found in the test just as a warning.
| # Find nearest pixel to r=45, dec=45. | ||
| nside = 128 | ||
| centerPixNumber = hp.ang2pix(nside, 45, 45, lonlat=True) | ||
| ra, dec = hp.pix2ang(nside, centerPixNumber, lonlat=True) |
There was a problem hiding this comment.
Perhaps add a test that the healpix pixel ra and dec are less than the size of a pixel away from the initial ra and dec.
There was a problem hiding this comment.
This would be testing healpy directly vs testing the wrappers that we have written so I'm not included to add this test. If ang2pix isn't working properly there would be more fundamental problems with healpy going on.
Fix call in query_disc
Debug/simplify unittest. Fix up some docs and code.
morriscb
force-pushed
the
tickets/DM-30673
branch
from
691a976
to
b409cec
Compare
No description provided.