Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-30560: Handle cases of incomputable Psfs in source injection #536

Merged
merged 1 commit into from Jun 17, 2021

Conversation

jmeyers314
Copy link
Contributor

Above error occasionally encountered when evaluating a
CoaddPsf in a region with no underlying exposures.

Copy link
Contributor

@morriscb morriscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight change to one of the log outputs for clarity of what is happening.

try:
psfArr = psf.computeKernelImage(pt).array
except InvalidParameterError:
logger.infof("Cannot compute Psf for object at {}; skipping", pt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log here is a bit of a misnomer as it the object isn't being skipped just yet assuming that the new point creation doesn't return the same position.

Above error occassionally encountered when evaluating a
CoaddPsf in a region with no underlying exposures.
@jmeyers314 jmeyers314 merged commit 433cadd into master Jun 17, 2021
@jmeyers314 jmeyers314 deleted the tickets/DM-30560 branch June 17, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants