DM-30843: Raise RepeatableQuantumError if HealSparsePropertyMapTask given inconsistent inputs. #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Jun 29, 2021
| @@ -570,7 +578,13 @@ def run(self, sky_map, tract, band, coadd_dict, input_map_dict, visit_summary_di | |||
| total_inputs[inmap] += 1 | |||
|
|
|||
| # Retrieve the correct visitSummary row | |||
| if visit not in visit_summary_dict: | |||
| msg = f"Visit {visit} not found in visit_summaries." | |||
There was a problem hiding this comment.
I go back and forth over time with this in my own code, so whatever you want to do is fine, but recently I have been more a fan of putting the message string right in the Exception constructor. Its sometimes less lines, and a bit clearer how they link together
There was a problem hiding this comment.
You know, I first wrote it as a single call (which I prefer in general!), but the message string was too long for the line and had to be split up anyway. I think this is more readable than a multi-line string, so I'm going to leave it as is.
| row = visit_summary_dict[visit].find(detector_id) | ||
| if row is None: | ||
| msg = f"Visit {visit} / detector_id {detector_id} not found in visit_summaries." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.