DM-30926: Add SkySources to ImageDifferenceTask #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug skySources codeblock.
morriscb
force-pushed
the
tickets/DM-30926
branch
from
1385792
to
d7f3e7a
Compare
kgabor
approved these changes
Jul 8, 2021
| @@ -318,6 +318,15 @@ class ImageDifferenceConfig(pipeBase.PipelineTaskConfig, | |||
| doc="Do not attempt to run task if template covers less than this fraction of pixels." | |||
| "Setting to 0 will always attempt image subtraction" | |||
| ) | |||
| doSkySources = pexConfig.Field( | |||
There was a problem hiding this comment.
I think doSkySources should not be allowed True if doDetection is False for consistency. In that case, the schema will be updated while the subtask is never run and diaSources will be returned as None and removed from the outputs (hopefully both in gen2 and gen3).
(There may be more inconsistencies around regarding what is done if doDetection is False in general; doDetection should perhaps be removed at some point....)
Set doSkySources default to False.
morriscb
force-pushed
the
tickets/DM-30926
branch
from
2767c88
to
2271abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.