DM-26651: Persist individual bright stars' warping Transforms, origin and number of rotations #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
reviewed
Jul 1, 2021
| @@ -375,7 +389,7 @@ def warpStamps(self, stamps, pixCenters): | |||
| nb90Rots = np.argmin(np.abs(possibleRots - float(yaw))) | |||
|
|
|||
| # apply transformation to each star | |||
| warpedStars = [] | |||
| warpedStars, warpTransforms, XY0s = [], [], [] | |||
There was a problem hiding this comment.
I think this should be xy0s, since we only capitalize class names, and the use of xy0 is common in the stack.
MorganSchmitz
force-pushed
the
tickets/DM-26651
branch
from
783176a
to
51e2bed
Compare
MorganSchmitz
force-pushed
the
tickets/DM-26651
branch
from
51e2bed
to
3353954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of two PRs for DM-26651, the other being in meas_algorithms.
Jira ticket
Jenkins run