DM-31060: Clean up some log usage #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All classes names "Test*" are inspected by pytest as possible test cases. It warns when it can't find any. Fix those warnings by renaming the classes.
Both work with lsst.log and python logging but `.warn` is deprecated by python logging.
Logging infrastructure is designed to work as:
log.warning("Message %s", msg)
and only do the string interpolation if the logger is going
to deliver the message. This commit changes code that does
log.warning("Message %s" % msg)
to the correct form.
isullivan
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.log.warn->self.log.warninglog.x("message: %s" % msg)->log.x("message: %s", msg)