Tickets/dm 6077 #56
Merged
Tickets/dm 6077 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some lines were too long and the explanation of the subtasks was out of date. Provide proper links to the correct APIs.
The PSF determiner is now a normal subtask, so construct it as one. This does not change how the PSF determiner is configured or called; it is a trivial change (though one gives all PSF determiners a log, and allows them to have a schema).
| The star selector is a subclass of | ||
| \ref lsst.meas.algorithms.starSelector.StarSelectorTask "lsst.meas.algorithms.StarSelectorTask" | ||
| and the PSF determiner is a sublcass of | ||
| \ref lsst.meas.algorithms.psfDeterminer.PsfDeterminerTask "lsst.meas.algorithms.PsfDeterminerTask" |
There was a problem hiding this comment.
Should be lsst.meas.algorithms.BasePsfDeterminerTask
There was a problem hiding this comment.
Yes. I pushed that fix after I asked you to review it and am a bit worried you are still seeing the older version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.