DM-30465 Implement decorrelation afterburner for maximum likelihood images #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Aug 17, 2021
| @@ -970,15 +970,26 @@ def run(self, exposure=None, selectSources=None, templateExposure=None, template | |||
| # useScoreImageDetection=True and doDecorrelation=True is not allowed in the config | |||
There was a problem hiding this comment.
This comment should be removed
Comment on lines
984
to
992
| else: | ||
| decorrResult = self.decorrelate.run(exposureOrig, subtractRes.warpedExposure, | ||
| subtractedExposure, | ||
| subtractRes.psfMatchingKernel, | ||
| spatiallyVarying=self.config.doSpatiallyVarying, | ||
| preConvKernel=None, | ||
| templateMatched=self.config.convolveTemplate, | ||
| preConvMode=False) | ||
| subtractedExposure = decorrResult.correctedExposure |
There was a problem hiding this comment.
I think we want to decorrelate the subtracted exposure, even if we use the score image for detection.
* Remove pre-convolution and decorrelation afterburner restriction in config. * Add support for likelihood image decorrelation.
isullivan
force-pushed
the
tickets/DM-30465
branch
from
d184a67
to
ab75a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.