DM-31507 Modify data-structures to aid ref counting #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
approved these changes
Aug 25, 2021
Comment on lines
143
to
147
| def _config(self) -> Optional[Config]: | ||
| return self._config_() |
There was a problem hiding this comment.
My general worry about this pattern is that previously _config was never None, while after this change it is possible (may be improbable) that weakref returns None if original Config is gone. Could you make it return Config instead of Optional[Config] and raise an exception if weakref object is deleted? This applies to other packages where you use the same method, I'm not going to comment on it there.
natelust
force-pushed
the
tickets/DM-31507
branch
from
ddce4d3
to
c85f590
Compare
It is desirable that variables get cleaned up when they go out of scope, meaning that their ref count must go to zero. Some objects kept closures or circular references which means they must be cleaned by the garbage collector which can happen at unpredictable times. Make these objects able to be dropped with reference counting.
natelust
force-pushed
the
tickets/DM-31507
branch
from
c85f590
to
4492682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is desirable that variables get cleaned up when they go out of
scope, meaning that their ref count must go to zero. Some objects
kept closures or circular references which means they must be
cleaned by the garbage collector which can happen at unpredictable
times. Make these objects able to be dropped with reference counting.