Review for DM-2837 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.sources = dict(g=0.0, r=0.0, true_g=-0.00928), dict(g=0.0, r=-1.0, true_g=-0.09168) | ||
| self.sources = (dict(g=0.0, r=0.0, fluxErr_g=0.0, fluxErr_r=0.0, true_g=-0.00928, true_fluxErr_g=0.0), | ||
| dict(g=0.0, r=-1.0, fluxErr_g=1.0, fluxErr_r=1.0, true_g=-0.09168, | ||
| true_fluxErr_g=0.92129230974756315)) |
There was a problem hiding this comment.
Where do all these hard-coded values come from?
There was a problem hiding this comment.
true_fluxErr_g should be below g=0.0.
AstroVPK
force-pushed
the
tickets/DM-2837
branch
2 times, most recently
from
a10e97a
to
35b02d5
Compare
The existing unittests for colorterms do not test the propagateFluxErrors function. This commit adds a simple unittest that propagates trivial flux errors.
The existing test1 in testPhotoCal that tests to see if zeropoint corrections are computed correctly was not applying any colorterm correction. This commit adds a test that essentially repeats test1 but with a trivial colorterm correction added to ensure that the colorterm machinary is working correctly.
The unittest Test1 to ensure that zeropoints could be computed has been renamed testZeroPoint.
RFC-69 mandates that all python unittests be runnable under py.test to allow for proper collection of test statistics etc... This commit updates the testColorterm.py and testPhotoCal.py tests to the py.test standard as outlined in SQR-012.
AstroVPK
force-pushed
the
tickets/DM-2837
branch
from
35b02d5
to
d6446a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.