Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-29628: Handle alignment of source injection from FITS files #570

Merged
merged 3 commits into from Oct 3, 2021

Conversation

jmeyers314
Copy link
Contributor

No description provided.

dtype=str,
allowed={
"wcs": (
"Local WCS from the input FITS image will align with local WCS "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would read better if it was written along the lines of "Local WCS from the input FITS image will be used to align it with the local WCS in the target image." maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, here's a proposed rewrite with more detail for both "wcs" and "pixel" options:

            "wcs": (
                "Input image will be transformed such that the local WCS in "
                "the FITS header matches the local WCS in the target image."
                "I.e., North, East, and angular distances in the input image "
                "will match North, East, and angular distances in the target "
                "image."
            ),
            "pixel": (
                "Input image will _not_ be transformed.  Up, right, and pixel "
                "distances in the input image will match up, right and pixel "
                "distances in the target image."
            )

@jmeyers314 jmeyers314 merged commit c9d3f51 into master Oct 3, 2021
@jmeyers314 jmeyers314 deleted the tickets/DM-29628 branch October 3, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants