DM-31491: Add default types to allow fakes propagation #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
force-pushed
the
tickets/DM-31491
branch
3 times, most recently
from
f2cab35
to
147febd
Compare
leeskelvin
reviewed
Oct 15, 2021
Comment on lines
+86
to
+90
| # This check is here because sometimes the WCS | ||
| # is multivalued and objects that should not be | ||
| # were being included. | ||
| gsPixScale = np.sqrt(gsWCS.pixelArea()) | ||
| if gsPixScale < pixScale/2 or gsPixScale > pixScale*2: |
There was a problem hiding this comment.
Is a gsPixScale offset of a factor of 2 sufficient to always capture this multivalued WCS issue, or will you still expect some level of failure? If sufficient, then that's fine. If it might continue to be an issue however, then perhaps this factor should be configurable?
There was a problem hiding this comment.
This was sufficient in testing, I think if it turns out not to be we need to do something more intelligent than this check. In which case I would like it to crash so we can figure out a better solution.
sr525
force-pushed
the
tickets/DM-31491
branch
3 times, most recently
from
f6225f8
to
5b70205
Compare
sr525
force-pushed
the
tickets/DM-31491
branch
from
5b70205
to
677a96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.