DM-32124: Include tract in dimensions of intermediate forcedSource #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natelust
approved these changes
Oct 25, 2021
ForcedPhotCcdTask includes tract in its dimensions which means that it produces an output catalog per-detector, per-tract. WriteForcedSourceTableTask which merges catalogs of forced measurements from calexps and diffims should do the same. TransformForcedSource temporally aggregates the forcedSource catalogs per-patch anyway. -rename forcedSourceTable to mergedForcedSourceTable because you cannot change the dimensions of an already registerd datasetType
yalsayyad
force-pushed
the
tickets/DM-32124
branch
from
54c7345
to
712bdd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForcedPhotCcdTask includes tract in its dimensions which means
that it produces an output catalog per-detector, per-tract.
WriteForcedSourceTableTask which merges catalogs of forced measurements from
calexps and diffims should do the same. TransformForcedSource temporally
aggregates the forcedSource catalogs per-patch anyway.
-rename forcedSourceTable to mergedForcedSourceTable because you cannot
change the dimensions of an already registerd datasetType