DM-30831: DcrAssembleCoaddConnections should inherit from AssembleCoaddConnections #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Nov 9, 2021
| @@ -97,8 +85,12 @@ class DcrAssembleCoaddConnections(pipeBase.PipelineTaskConnections, | |||
|
|
|||
| def __init__(self, *, config=None): | |||
| super().__init__(config=config) | |||
| self.outputs.remove("coaddExposure") | |||
There was a problem hiding this comment.
I assume these are part of AssembleCoaddConnections but this method does not output them, correct? If that's the case please add a comment here to the explaining why these two outputs are removed.
| dimensions=("tract", "patch", "band", "skymap"), | ||
| defaultTemplates={"inputCoaddName": "deep", | ||
| defaultTemplates={"inputWarpName": "deep", |
There was a problem hiding this comment.
Is the inputWarpName template here in case you want to have different warps and coadds? Is that a possible or expected mode of operation?
There was a problem hiding this comment.
Yes, these will be different in general. I'll add a comment.
isullivan
force-pushed
the
tickets/DM-30831
branch
from
455827b
to
37d0b4f
Compare
isullivan
force-pushed
the
tickets/DM-30831
branch
from
37d0b4f
to
ca8da93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.