DM-32549: Supply position for psf shape computations #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-32549
branch
from
aae71c6
to
c044b75
Compare
mrawls
reviewed
Dec 1, 2021
Comment on lines
1326
to
1327
| tempalteAvgPos = templatePsf.getAveragePosition() | ||
| psfRefSize = templatePsf.computeShape(tempalteAvgPos).getDeterminantRadius()*sigma2fwhm |
There was a problem hiding this comment.
Suggested change
| tempalteAvgPos = templatePsf.getAveragePosition() | |
| psfRefSize = templatePsf.computeShape(tempalteAvgPos).getDeterminantRadius()*sigma2fwhm | |
| templateAvgPos = templatePsf.getAveragePosition() | |
| psfRefSize = templatePsf.computeShape(templateAvgPos).getDeterminantRadius()*sigma2fwhm |
| @@ -1319,7 +1321,10 @@ def selectCoaddPsf(self, templateCoadd, warpRefList): | |||
| # Note: ``ccds`` is a `lsst.afw.table.ExposureCatalog` with one entry per ccd and per visit | |||
| # If there are multiple ccds, it will have that many times more elements than ``warpExpRef`` | |||
| ccds = templateCoadd.getInfo().getCoaddInputs().ccds | |||
| psfRefSize = templateCoadd.getPsf().computeShape().getDeterminantRadius()*sigma2fwhm | |||
| templatePsf = templateCoadd.getPsf() | |||
There was a problem hiding this comment.
Is saving templatePsf really needed here or can we use it on the fly like all the other instances? You don't assign calPsf for instance, you just use cal.getPsf().stuff
isullivan
force-pushed
the
tickets/DM-32549
branch
from
c044b75
to
41d9336
Compare
isullivan
force-pushed
the
tickets/DM-32549
branch
from
41d9336
to
224f23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the changes to ImageDifferenceTask are being done separately on DM-31777.