Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-31990: Add configuration option to set coverage nside for survey-wide HealSparsePropertyMaps #609

Merged
merged 3 commits into from Dec 2, 2021

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Nov 30, 2021

No description provided.

Copy link
Contributor

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like the addition of the context managers to catch the warnings.

doc="Consolidated HealSparse coverage map nside. Must be power of 2.",
dtype=int,
default=32,
check=_is_power_of_two,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know check in a PexConfig is a thing.

This warning is only important if you are trying to build a large
map, and for patch input maps the high resolution coverage is okay.
@erykoff erykoff merged commit 7497abf into main Dec 2, 2021
@erykoff erykoff deleted the tickets/DM-31990 branch December 2, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants