DM-27013: Change CalibrateTask refcat defaults to Gaia DR2 for astrometry and PS1 for photometry #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-27013
branch
from
fc5432c
to
88f551c
Compare
parejkoj
force-pushed
the
tickets/DM-27013
branch
from
88f551c
to
b0fb32a
Compare
parejkoj
force-pushed
the
tickets/DM-27013
branch
from
b0fb32a
to
b5da985
Compare
leeskelvin
reviewed
Apr 15, 2022
Comment on lines
+324
to
+330
| # NOTE: these two lines are for gen2, and are only here for compatibility. | ||
| self.astromRefObjLoader.ref_dataset_name = "gaia_dr2_20200414" | ||
| self.photoRefObjLoader.ref_dataset_name = "ps1_pv3_3pi_20170110" |
There was a problem hiding this comment.
Do we still need to support gen2 functionality?
There was a problem hiding this comment.
Yes, until the gen2 refcat code is completely removed we do need to support this (because there are consistency checks in various places that will remain until after that removal).
parejkoj
force-pushed
the
tickets/DM-27013
branch
from
b5da985
to
16680e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.