DM-31388: Investigate low fake injection completeness in HSC COSMOS #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
force-pushed
the
tickets/DM-31388
branch
from
885b67b
to
1f71eda
Compare
|
I verified that these changes notably improve the fakes completeness situation for DECam, and do not make it worse for HSC. The root of the original ticket ("investigate low fake injection completeness in HSC Cosmos") will be moved to a new ticket for further investigation, but at least we know it's not this. |
mrawls
force-pushed
the
tickets/DM-31388
branch
2 times, most recently
from
27f2815
to
0448fd0
Compare
|
Following pair coding, insertFakes is now, theoretically, better. @sr525 kindly agreed to do some kind of reality check on this as part of her review. |
sr525
reviewed
Feb 16, 2022
mrawls
force-pushed
the
tickets/DM-31388
branch
2 times, most recently
from
9c67871
to
f9b6f77
Compare
mrawls
force-pushed
the
tickets/DM-31388
branch
2 times, most recently
from
60a9492
to
b1a3296
Compare
sr525
reviewed
Mar 3, 2022
mrawls
force-pushed
the
tickets/DM-31388
branch
4 times, most recently
from
c8b7858
to
43df84a
Compare
WCS inaccuracies away from the chip can lead to problems when filtering only in image pixel space. This uses the new containsSkyCoords exposure method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status has fixes from pair coding with @ebellm @sr525 and me. We added RA + Dec filtering prior to inserting and matching fakes, so fake sources far from the sky region under consideration are never used.
I intend to rerun matchFakesTask on the ~recent large HSC and DECam ApPipe reruns and see if the problems pertaining to completeness and fakes showing up in ridiculous places go away.