DM-33279: Add IsolatedStarAssociationTask #633
Conversation
erykoff
force-pushed
the
tickets/DM-33279
branch
from
deb0995
to
552d208
Compare
erykoff
force-pushed
the
tickets/DM-33279
branch
from
552d208
to
0ac79aa
Compare
erykoff
force-pushed
the
tickets/DM-33279
branch
from
a9767b2
to
46c2611
Compare
| Processing summary | ||
| ================== | ||
|
|
||
| ``IsolatedStarAssociationTask`` reads in all the visit-level source table parquet catalogs in a given tract and matches (associates) the observations together. |
There was a problem hiding this comment.
Worth linking to the ConsolidateSourceTableTask or something here? We sadly don't have actual datasetType docs yet, nor a way to link to them.
There was a problem hiding this comment.
I don't know how to do that, and since there's no guidance to how to do the dataset linkages I'd prefer to let it go for now...
| ########################### | ||
|
|
||
| ``IsolatedStarAssociationTask`` matches unresolved stars from the ``sourceTable_visit`` datasets into a pure (but not complete) catalog of isolated stars. | ||
| The output datasets are a catalog of isolated stars (dataset ``isolated_star_cat``) and the associated observations with configured columns from the input catalogs (dataset ``isolated_star_observations``). |
There was a problem hiding this comment.
"and the associated observations" -> "and a catalog of properties from each of the associated sources"? Trying to keep object/source terminology (since I think we use "source" where you're using "observation" here)? Which maybe suggests isolated_star_observations should be isolated_star_sources, or maybe I'm misunderstanding something.
I think "observation" in Rubin typically implies properties about the exposure itself, not the sources?
There was a problem hiding this comment.
I think you're right, and that's a good catch before things get embedded in the system.
| - Unflagged, unresolved stars above a configured signal-to-noise are selected from each input catalog. | ||
| - The input stars are associated within a configured ``match_radius``. | ||
| This association is done band-by-band (with the order configured by ``band_order``), and then each band is matched such that all observations are associated with a unique list of stars which cover all the bands in the tract. | ||
| - The star catalog is matched against itself and group of stars that matches neighbor(s) within ``isolation_radius`` is removed from the final isolated star catalog (``isolated_star_cat``). |
There was a problem hiding this comment.
"and group of stars that matches" - I think something's not right with the grammar here, but I can't figure out what.
erykoff
force-pushed
the
tickets/DM-33279
branch
from
1cf3336
to
5f4cf90
Compare
This PR adds a new isolated star association task for input to re-estimating the psf with consistently reserved stars, and for input to fgcmcal.
Note that the
Matchercode currently in the commit is just there for testing purposes until DM-33545 is finished and we have a new env withspherematch.