Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33786: Remove try block for stacking #636

Merged
merged 1 commit into from Feb 24, 2022
Merged

DM-33786: Remove try block for stacking #636

merged 1 commit into from Feb 24, 2022

Conversation

yalsayyad
Copy link
Contributor

because log.fatal does not exit.
There is still a log.debug that prints each bbox in the loop
if more info on which subregion it is working on is needed.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so the thought was that the fatal log would exit, but instead it just continued with a bad section? And removing this will let it die in peace.

@yalsayyad yalsayyad merged commit 5d7e2d8 into main Feb 24, 2022
@yalsayyad yalsayyad deleted the tickets/DM-33786 branch February 24, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants