DM-33888: Add config parameter to grow streak footprints #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
reviewed
Mar 22, 2022
| @@ -2012,6 +2012,11 @@ class CompareWarpAssembleCoaddConfig(AssembleCoaddConfig, | |||
| dtype=bool, | |||
| default=False | |||
| ) | |||
| growStreakFp = pexConfig.Field( | |||
| doc="Grow streak footprints by this number x the PSF width", | |||
There was a problem hiding this comment.
Would this read more clearly if it were written as:
"Grow streak footprints by this number multiplied by the PSF width"
or
"Grow streak footprints by this number multiplied by the PSF determinant radius"
?
cmsaunders
force-pushed
the
tickets/DM-33888
branch
from
2102518
to
d97a310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter that allows the streak footprints to be grown by the parameter times the PSF width.