add fits reader #64
Merged
add fits reader #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few PEP8 tweaks, plus remove linefeeds from a config field doc string and standardize the indentation for one block of code.
Use standard alias for numpy and move the import to the standard location
Change TextReaderTask._DefaultName to 'catalogReader' a name sufficiently generic to be used by variant readers.
Add a new catalog reader FitsReaderTask and associated config to read catalogs from FITS files. Add a test for the new task in a new test file tests/testIndexReference.py (which presently on has the one test)
Apply autopep8, remove unused imports, and stop setting unused variables.
import numpy -> import numpy as np
import testFindAstrometryNetDataDir ->
from . import testFindAstrometryNetDataDir
standardize grouping of imports
|
|
||
|
|
||
| class MyMemoryTestCase(lsst.utils.tests.MemoryTestCase): | ||
| pass |
There was a problem hiding this comment.
Is it legal to have a memory test that just passes?
There was a problem hiding this comment.
Yes. Take a look at https://developer.lsst.io/coding/python_testing.html
Rename TextReaderTask/Config to ReadTextCatalogTask/Config Rename FitsReaderTask/Config to ReadFitsCatalogTask/Config Rename "readFile" method to "run" Update unit tests accordingly
Move catalog reader tasks to new module readCatalog.py Rename tests/testIndexReference.py to tests/testReadCatalog.py since it only tests a reader
Add missing from __future__ import absolute_import, division, print_function to all three index catalog reader modules
Also put table columns into a more reasonable order, since the code no longer rearranges them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.