New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-33910: Write PipelineTask to detect Cosmic Rays on difference images #643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the large number of comments! There is a lot of code that can still be removed, and the documentation needs to be updated.
Beyond the cleanup, the most significant change I'm requesting is removing repairPostDiff.py
entirely, and just using the existing repair.py
. I think that one should work as-is, so the code duplication is unnecessary.
Something went haywire during that filesystem problem when I was trying to push stuff. I've got a good copy of cosmicRayPostDiff.py now; I think the easiest thing to do is to delete the ticket branch in git, remake it, copy the file (post-review changes included) in, and proceed that way. |
d0338ff
to
63d7324
Compare
OK, finally fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I had a few fairly minor comments for cleaning it up.
final cleanup
63d7324
to
41d7fde
Compare
No description provided.