Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33910: Write PipelineTask to detect Cosmic Rays on difference images #643

Merged
merged 1 commit into from Mar 28, 2022

Conversation

kherner
Copy link
Contributor

@kherner kherner commented Mar 9, 2022

No description provided.

Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the large number of comments! There is a lot of code that can still be removed, and the documentation needs to be updated.

Beyond the cleanup, the most significant change I'm requesting is removing repairPostDiff.py entirely, and just using the existing repair.py. I think that one should work as-is, so the code duplication is unnecessary.

python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/repairPostDiff.py Outdated Show resolved Hide resolved
@kherner
Copy link
Contributor Author

kherner commented Mar 24, 2022

Something went haywire during that filesystem problem when I was trying to push stuff. I've got a good copy of cosmicRayPostDiff.py now; I think the easiest thing to do is to delete the ticket branch in git, remake it, copy the file (post-review changes included) in, and proceed that way.

@kherner
Copy link
Contributor Author

kherner commented Mar 25, 2022

Something went haywire during that filesystem problem when I was trying to push stuff. I've got a good copy of cosmicRayPostDiff.py now; I think the easiest thing to do is to delete the ticket branch in git, remake it, copy the file (post-review changes included) in, and proceed that way.

OK, finally fixed.

Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had a few fairly minor comments for cleaning it up.

python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
python/lsst/pipe/tasks/cosmicRayPostDiff.py Outdated Show resolved Hide resolved
@kherner kherner merged commit 7f758e8 into main Mar 28, 2022
@kherner kherner deleted the tickets/DM-33910 branch March 28, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants