DM-34452: Deprecate calibrate.doInsertFakes and remove gen2-only tests. #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Apr 14, 2022
| doc="Run fake sources injection task" | ||
| doc="Run fake sources injection task", | ||
| deprecated=("doInsertFakes is no longer supported. This config will be removed after v24. " | ||
| "Please use ProcessCcdWithFakesTask instead.") |
There was a problem hiding this comment.
I believe this is accurate right now, but @leeskelvin should know about it so he can fix it when the recommendation for what to use instead changes, since that's also in the works.
There was a problem hiding this comment.
ProcessCcdWithFakesTask will itself become obsolete soon, as we transition to using VisitInjectTask and CoaddInjectTask within the new source_injection repo. But yes, for the time being, this is correct.
erykoff
force-pushed
the
tickets/DM-34452
branch
from
2453798
to
86dd626
Compare
sr525
reviewed
Apr 15, 2022
| hasFakes = Field( | ||
| dtype=bool, | ||
| default=False, | ||
| doc="Should be set to True if fake sources have been inserted into the input data." | ||
| doc="Should be set to True if fake sources have been inserted into the input data.", | ||
| deprecated="hasFakes is no longer supported. This config will be removed after v24." | ||
| ) |
There was a problem hiding this comment.
This option is from the newer round of fakes insertion changes and is probably going to be deprecated as part of the moving to gen 3 only but might be a different round of removals.
There was a problem hiding this comment.
It needs to have the same deprecation warning as processCcdWithFakes and friends.
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| exposure = patchRef.get("fakes_" + self.config.coaddName + "Coadd", immediate=True) | ||
| else: | ||
| exposure = patchRef.get(self.config.coaddName + "Coadd", immediate=True) | ||
| exposure = patchRef.get(self.config.coaddName + "Coadd", immediate=True) |
There was a problem hiding this comment.
This goes with the hasFakes config option above.
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| patchRef.put(results.outputExposure, "fakes_" + coaddName + "_calexp") | ||
| else: | ||
| patchRef.put(results.outputExposure, coaddName + "_calexp") | ||
| patchRef.put(results.outputExposure, coaddName + "_calexp") |
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| @@ -365,7 +360,8 @@ class DeblendCoaddSourcesConfig(Config): | |||
| coaddName = Field(dtype=str, default="deep", doc="Name of coadd") | |||
| hasFakes = Field(dtype=bool, | |||
| default=False, | |||
| doc="Should be set to True if fake sources have been inserted into the input data.") | |||
| doc="Should be set to True if fake sources have been inserted into the input data.", | |||
| deprecated=("hasFakes is no longer supported. This config will be removed after v24.")) | |||
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| coaddType = "fakes_" + self.config.coaddName | ||
| else: | ||
| coaddType = self.config.coaddName | ||
| coaddType = self.config.coaddName |
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| @@ -762,7 +755,8 @@ class MeasureMergedCoaddSourcesConfig(PipelineTaskConfig, | |||
| hasFakes = Field( | |||
| dtype=bool, | |||
| default=False, | |||
| doc="Should be set to True if fake sources have been inserted into the input data." | |||
| doc="Should be set to True if fake sources have been inserted into the input data.", | |||
| deprecated="hasFakes is no longer supported. This config will be removed after v24." | |||
sr525
reviewed
Apr 15, 2022
python/lsst/pipe/tasks/multiBand.py
Outdated
| coaddType = "fakes_" + self.config.coaddName | ||
| else: | ||
| coaddType = self.config.coaddName | ||
| coaddType = self.config.coaddName |
erykoff
force-pushed
the
tickets/DM-34452
branch
from
86dd626
to
17ef066
Compare
erykoff
force-pushed
the
tickets/DM-34452
branch
from
17ef066
to
4394a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.