DM-6999: Logging framework migration #69
Conversation
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
8fede7d
to
be17ef7
Compare
hsinfang
force-pushed
the
tickets/DM-6999
branch
2 times, most recently
from
cc120e9
to
3e1d80d
Compare
| from lsst.pipe.tasks.makeCoaddTempExp import MakeCoaddTempExpTask | ||
|
|
||
| pexLog.Trace.setVerbosity('lsst.coadd', 3) | ||
| pexLog.Trace.setVerbosity('lsst.ip.diffim', 1) |
There was a problem hiding this comment.
@r-owen , I removed these because I thought they were accidentally left here. Are they here intentionally? If so I will add them back in the lsst.log form.
There was a problem hiding this comment.
That's a great question and I'm afraid I don't know the answer. I had assumed they provided an appropriate level of verbosity, but perhaps it is too much.
There was a problem hiding this comment.
I don't think tasks should be messing with trace levels. It's up to the user to turn tracing on.
There was a problem hiding this comment.
Agree. I'll keep this commit, with those verbosity setting removed.
If coadd and ip_diffim need to be more verbose, we probably should change the logging records to a higher level in coadd and ip_diffim. (I can file a ticket if that is wanted)
No log records from meas.astrom.astrometry_net or meas.astrom.sip show up by running this test with the current master. Instead, there are some log messages from LoadIndexedReferenceObjectsTask. Update the code to quiet down the new noisy logging.
Make changes for tasks' logs and other individual logging to use lsst.log. Replace lsst.pex.logging logdebug with lsst.log.Log DEBUG level
hsinfang
force-pushed
the
tickets/DM-6999
branch
from
3e1d80d
to
b07f4d5
Compare
No description provided.