DM-35386 Fix Serialization of ConfigurableActionStructField #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nit-picky, but the PR title should have a
I don't pretend to fully understand the fix (e.g. I don't know why the |
laurenam
approved these changes
Jul 5, 2022
| @@ -355,8 +358,11 @@ def toDict(self, instance): | |||
| def save(self, outfile, instance): | |||
| actionStruct = self.__get__(instance) | |||
| fullname = _joinNamePath(instance._name, self.name) | |||
|
|
|||
| # ensure that a struct is always empty before assigning to it | |||
There was a problem hiding this comment.
Another nit-pick: Comments are supposed to start capitalized.
Fields were not being properly initialized empty when serialized. This caused state from a default instantiation of a class to add state back into a de-serialized object when it should not be there.
natelust
force-pushed
the
tickets/DM-35386
branch
from
0b50a23
to
98e8933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields were not being properly initialized empty when serialized.
This caused state from a defaunt instatiation of a class to add
state back into a de-serialized object when it should not be
there.