Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35035: Remove gen2 curated calibration code #703

Merged
merged 2 commits into from Jul 26, 2022
Merged

DM-35035: Remove gen2 curated calibration code #703

merged 2 commits into from Jul 26, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jul 26, 2022

The core reader code has been moved to lsst/obs_base#424

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry I missed that gen2 test previously!

@erykoff
Copy link
Contributor

erykoff commented Jul 26, 2022

One more question I just realized: this code used to be a public interface in pipe_tasks but is now private in obs_base. Is there a need to do a deprecated forwarding here?

@timj
Copy link
Member Author

timj commented Jul 26, 2022

read_all was public because obs_base needed to call it. The real public interface was the gen2 ingestCuratedCalibs.py. I was pondering whether read_all should be public in obs_base to allow Instrument subclasses to call it directly but I decided not to unless we need it because the actual curated calibrations interface in Instrument is much better. If we want this code to hang around for a deprecation cycle I should bring it back rather than calling obs_base because the interface has changed in obs_base. Given there's a tiny chance that someone has used read_all outside of a butler context (Which is tiny since they also need the corresponding obs_*_data package layout) then I'll bring it back and add a deprecation.

timj added 2 commits July 26, 2022 08:38
The core reader code has been moved to obs_base but is retained
here for a deprecation cycle.
@timj
Copy link
Member Author

timj commented Jul 26, 2022

I've added the deprecation message.

@timj timj merged commit 10f10f6 into main Jul 26, 2022
@timj timj deleted the tickets/DM-35035 branch July 26, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants