DM-7235: Pytest updates #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroVPK
force-pushed
the
tickets/DM-7235
branch
from
4a1518c
to
6c4e663
Compare
| utilsTests.run(suite()) | ||
| class MatchMemoryTestCase(lsst.utils.tests.MemoryTestCase): | ||
| pass | ||
|
|
There was a problem hiding this comment.
Is there a desire to homogenize the name of the memory test class? I see three different ones here (none of which are TestMemory as suggested in @timj's slides & the DM Developer Guide).
There was a problem hiding this comment.
The name doesn't matter. I have no opinion on whether it should be standardized.
|
With the caveat that I am currently unable to actually pull this down & run it myself, this all looks fine, but please consider the following:
|
AstroVPK
force-pushed
the
tickets/DM-7235
branch
from
b96a306
to
51ecda8
Compare
This commit updates some of the tests to use the py.test framework. This includes checking for bad uses of assert_, assertEquals, and assertTrue, the lsstUtils alias, as well as cleaning up the test code with autopep8 to comply with the LSST PEP8 standard.
This required extensive modifications so that the data creation happens only once.
A few of the tests in pipe_tasks have non-standard names i.e. names that do not begin with test. This commit renames those tests by adding 'test' in front of the old name and capitalizing the former first character.
AstroVPK
force-pushed
the
tickets/DM-7235
branch
from
ea923a1
to
b7d3ea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.