DM-37411: Add visit-level PSF model robustness metrics #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-37411
branch
from
f5714fb
to
4d33e23
Compare
TallJimbo
approved these changes
Jan 4, 2023
| psfSampling = pexConfig.Field( | ||
| dtype=int, | ||
| doc="Factor by which to subsample the masked image in each dimension for the maxDistToNearestPsf " | ||
| "metric caclulation (the tradeoff is between adequate sampling versus improves speed).", |
There was a problem hiding this comment.
"improves" -> "improved" (also below), or just drop "improves" entirely.
| @@ -69,6 +69,24 @@ class ComputeExposureSummaryStatsConfig(pexConfig.Config): | |||
| dtype=str, | |||
| default="base_SdssShape_psf" | |||
| ) | |||
| psfSampling = pexConfig.Field( | |||
| dtype=int, | |||
| doc="Factor by which to subsample the masked image in each dimension for the maxDistToNearestPsf " | |||
There was a problem hiding this comment.
"Factor by which to subsample" reads to me as the number of points in the grid in each dimension, not the step size. How about "Sampling rate in pixels in each dimension for the maxDistToNearestPsf grid"?
This adds the following two metrics to the computeExposureSummaryStats
task:
maxDistToNearestPsf: the maximum distance (in pixels) of an unmasked pixel
to its nearest PSF star (i.e. star that was used in
the PSF modeling).
psfTraceRadiusDelta: the delta (in pixels) between the maximum and minimum
model PSF trace radius values evaluated on a grid of
points lying in the unmasked region of the image. Set
to NaN if any of the model PSF trace values evaluate
to NaN.
These metrics may be used downstream as thresholded criteria for
inclusion in coaddition.
Namely, add a threshold on maxPsfTraceRadiusDelta. The default value was conditioned on the HSC-RC2 dataset.
laurenam
force-pushed
the
tickets/DM-37411
branch
from
4d33e23
to
edc6b08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.