New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-36408: Add Coadd PSF and multiband source fitting tasks #749
Conversation
f0cf406
to
b998070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments and minor changes requested. Although there seems to be a lot of duplicate code between the different tasks, and I wonder if you could abstract more of it out?
About the duplication - I accidentally left in a couple of unnecessary methods in the PSF fitting task. Other than the base
|
No, I don't think that you need to deprecate lsst-dm code. |
I meant deprecating the |
Right, sorry, that's what I meant too. Even though the task is in |
72d824f
to
301e94a
Compare
This task is essentially an interface that was only ever implemented in lsst-dm repos that are no longer in active use and likely bitrotted. Furthermore, the design is a monolith that does PSF and source modelling, which is a pattern we are trying to discourage.
301e94a
to
3047892
Compare
These tasks operate on coadd images and are meant to be run sequentially, in contrast to the old monolithic fitting
MultibandFitTask
infit_multiband.py
, which did both PSF and source fitting in one task. Also, unlike the old task (which will be deprecated soon), the outputs are astropy tables rather thanSourceCatalog
s. The structure is otherwise similar, with the actual work done by a configurable subtask (not included).