DM-37865: Remove unused parameters from deferred dataset handle get calls #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Feb 6, 2023
| @@ -539,7 +539,7 @@ def __init__(self, butler=None, schema=None, peakSchema=None, refObjLoader=None, | |||
| schema = initInputs['inputSchema'].schema | |||
| if schema is None: | |||
| assert butler is not None, "Neither butler nor schema is defined" | |||
| schema = butler.get(self.config.coaddName + self.inputCatalog + "_schema", immediate=True).schema | |||
| schema = butler.get(self.config.coaddName + self.inputCatalog + "_schema").schema | |||
There was a problem hiding this comment.
Wait, are tasks ever initialized with a butler in gen3?
There was a problem hiding this comment.
I was wondering. The code is clearly never called because if it was called it would break... I wasn't brave enough to remove the butler parameter completely from the 8 places that use it but maybe I should.
There was a problem hiding this comment.
I don't think I want to get into that on this ticket though.
These were used in gen2 but are no longer relevant.
This has not been allowed for a long time and suggests that we have no code coverage of these lines.
It was reliant on a gen2 dataset handle and is not used in any gen3 code.
timj
force-pushed
the
tickets/DM-37865
branch
from
7475822
to
b670041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datasetTypeandimmediateparameters were for gen2 but will imminently not be allowed in gen3 (they are currently ignored).