DM-36649 Move configurable actions to Pex_Config #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
reviewed
Feb 9, 2023
Comment on lines
3
to
6
| warnings.warn('lsst.pipe.tasks.configurableActions is deprecated; ' | ||
| 'it has been moved to lsst.pex.config.configurableActions. ' | ||
| 'Accessing though lsst.pipe.tasks will be removed from ' | ||
| 'Science Pipelines after release 26.0.0', category=FutureWarning) |
There was a problem hiding this comment.
Would this read better in double quotes and indented thus?
warnings.warn(
"lsst.pipe.tasks.configurableActions is deprecated; "
"it has been moved to lsst.pex.config.configurableActions. "
"Accessing though lsst.pipe.tasks will be removed from "
"Science Pipelines after release 26.0.0",
category=FutureWarning,
)
leeskelvin
approved these changes
Feb 9, 2023
The configurableAction code has been moved to pex_config on branch tickets/DM-36649-transfer.
natelust
force-pushed
the
tickets/DM-36649
branch
from
44ef3ac
to
4925a81
Compare
Configurable actions have moved to pex_config with only a stub remaining in pipe_tasks. This stub is not a package and thus cannot be checked with package import syntax. Tests on this code live in pex_config now.
natelust
force-pushed
the
tickets/DM-36649
branch
from
4925a81
to
1a8a94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.