DM-6815: Update LSST full-stack processing configuration to match best practice from HSC #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ class CoaddBaseConfig(pexConfig.Config): | |||
| doApplyUberCal = pexConfig.Field( | |||
| dtype = bool, | |||
| doc = "Apply meas_mosaic ubercal results to input calexps?", | |||
| default = False | |||
| default = True | |||
There was a problem hiding this comment.
I'm concerned this will break cameras other than HSC running with meas_mosaic.
These match the battle-tested values in use for current HSC production runs (HSC version 4.0.3).
Due to the changes to config parameters in DM-6815 (https://jira.lsstcorp.org/browse/DM-6815), in particular setting doTempLocalBackground=True (see also https://jira.lsstcorp.org/browse/RFC-212) and useApprox=True, the image characterization, detection, and measurement have slightly different behaviour. The test values are updated accordingly here.
laurenam
force-pushed
the
u/lauren/DM-6815
branch
from
0d093dc
to
3f8730a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.