Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37955: Update tasks and tests with new robust aperture correction. #760

Merged
merged 3 commits into from Mar 7, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Feb 28, 2023

No description provided.

@@ -417,11 +417,12 @@ def run(self, exposure, exposureIdInfo=None, background=None):
# if wanted
self.measurement.run(measCat=dmeRes.sourceCat, exposure=dmeRes.exposure,
exposureId=exposureIdInfo.expId)
# Run the catalog calculations before aperture correction.
self.catalogCalculation.run(dmeRes.sourceCat)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potential problem. We actually invented CatalogCalculations as a separate class of plugin from the "measurement" ones in order to have a round that runs after aperture corrections have been applied, since the archetypal catalog calculation is Extendedness, and that only works if the PSF fluxes and galaxy-model fluxes have been put on the same system.

I'm guessing you're moving this earlier so the star selector can use Extendedness, but it's not going to be any good before aperture corrections are applied - or at least it's not going to be as good then as it ought to be, even if it's being fed the Gaussian fluxes instead of CModel fluxes and that puts a ceiling on how good it can be.

Easiest potential way out of this would be to not use extendedness to feed aperture correction measurement, if we can get away with that. We might want to add a different S/G classification cut that just uses source to PSF size ratios somewhere else, like the science source selector, as a replacement.

@erykoff erykoff merged commit 03fd65e into main Mar 7, 2023
@erykoff erykoff deleted the tickets/DM-37955 branch March 7, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants