DM-38472: Reformat Bright Star Subtraction Processing Tasks #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-38472
branch
3 times, most recently
from
40bab59
to
2dc20e8
Compare
leeskelvin
changed the title
leeskelvin
force-pushed
the
tickets/DM-38472
branch
2 times, most recently
from
70b5f2e
to
45360de
Compare
timj
reviewed
Apr 28, 2023
leeskelvin
force-pushed
the
tickets/DM-38472
branch
3 times, most recently
from
cd2d5ea
to
16b3947
Compare
arunkannawadi
approved these changes
Apr 28, 2023
| from lsst.afw import math as afwMath | ||
| from lsst.afw.fits import Fits, readMetadata | ||
| from lsst.afw.image import ImageF, MaskedImageF, MaskX | ||
| from lsst.afw.math import StatisticsControl, statisticsStack, stringToStatisticsProperty |
There was a problem hiding this comment.
Just out of curiosity, why do you prefer importing the stuff you need rather than importing the library and using it from there? Is it simply to reduce the line length when they appear later?
There was a problem hiding this comment.
Reducing line length is certainly a consideration, yes. I find the code more readable later on if my imports do the heavy lifting above. I also like that the imports are explicit about what is being used in this package. However, I'm certainly not committed to one way or the other, and would consider changing back if needs be?
With that said, following our discussion earlier in the week, I'll leave this as-is for now. Thanks for the useful discussions!
leeskelvin
force-pushed
the
tickets/DM-38472
branch
from
16b3947
to
e658f7a
Compare
leeskelvin
force-pushed
the
tickets/DM-38472
branch
from
e658f7a
to
f8db1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.