DM-38846: Remove ImageDifferenceTask #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Useful diagnostic for the degree of astrometric shift between snaps. | ||
| diffKern = diffRet.psfMatchingKernel | ||
| width, height = diffKern.getDimensions() | ||
| raise NotImplementedError("PSF-matching of snaps is not yet supported.") |
There was a problem hiding this comment.
It looks to me that we have stopped supporting a feature that used to be possible earlier. Was this ever deprecated?
There was a problem hiding this comment.
No, this functionality has never actually been supported. We will need to add it, but it will be cleaner to start fresh than to try to use this very old code.
The deleted Task can be found for reference in https://github.com/lsst-dm/legacy-diffim
The replacement Tasks can be found in lsst.ip.diffim.subtractImages
isullivan
force-pushed
the
tickets/DM-38846
branch
from
f98112c
to
cc021ac
Compare
arunkannawadi
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated
ImageDifferenceTask, and the supporting code fromlsst.ip.diffim. Removing the supporting code also required removing the ancientlsst.ip.diffim.SnapPsfMatchTask.