Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39203: Add a moment-based star-galaxy classifier #792

Merged
merged 3 commits into from
Jan 30, 2024
Merged

DM-39203: Add a moment-based star-galaxy classifier #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a71e8a9
Add moment-based classifier to the ObjectTable
arunkannawadi May 26, 2023
450f750
Add sizeExtendedness to tests
arunkannawadi May 30, 2023
ec04b45
Include sizeExtendedness plugin
arunkannawadi May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/lsst/pipe/tasks/calibrateImage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ def setDefaults(self):
"base_CircularApertureFlux",
"base_GaussianFlux",
"base_PsfFlux",
"base_ClassificationSizeExtendedness",
]
self.psf_source_measurement.slots.shape = "ext_shapeHSM_HsmSourceMoments"
# Only measure apertures we need for PSF measurement.
Expand Down Expand Up @@ -301,6 +302,7 @@ def setDefaults(self):
"base_GaussianFlux",
"base_PsfFlux",
"base_CircularApertureFlux",
"base_ClassificationSizeExtendedness",
]
self.star_measurement.slots.psfShape = "ext_shapeHSM_HsmPsfMoments"
self.star_measurement.slots.shape = "ext_shapeHSM_HsmSourceMoments"
Expand Down
1 change: 1 addition & 0 deletions python/lsst/pipe/tasks/characterizeImage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ def setDefaults(self):
"base_GaussianFlux",
"base_PsfFlux",
"base_CircularApertureFlux",
"base_ClassificationSizeExtendedness",
]
self.measurement.slots.shape = "ext_shapeHSM_HsmSourceMoments"

Expand Down
10 changes: 10 additions & 0 deletions schemas/Object.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,14 @@ funcs:
functor: Column
args: base_ClassificationExtendedness_value
dataset: meas
refSizeExtendedness:
functor: Column
args: base_ClassificationSizeExtendedness_value
dataset: ref
sizeExtendedness:
functor: Column
args: base_ClassificationSizeExtendedness_value
dataset: meas
# lcPeriodic: # Not computed. Need multi-epoch forced phot S19
# lcNonPeriodic: # Not computed. Need without multi-epoch forced phot S19
# photoZ: # Not computed yet
Expand Down Expand Up @@ -760,6 +768,7 @@ flags:
- base_PixelFlags_flag_streak
- base_PixelFlags_flag_streakCenter
- base_ClassificationExtendedness_flag
- base_ClassificationSizeExtendedness_flag
- calib_astrometry_used
- calib_photometry_reserved
- calib_photometry_used
Expand Down Expand Up @@ -836,6 +845,7 @@ flag_rename_rules:
- ['base_Blendedness', 'blendedness']
- ['base_PixelFlags_flag', 'pixelFlags']
- ['base_ClassificationE', 'e']
- ['base_ClassificationS', 's']
- ['base_Psf', 'psf']
- ['base_CircularApertureFlux', 'apFlux']
- ['base_FootprintArea', 'footprintArea']
Expand Down
5 changes: 5 additions & 0 deletions schemas/Source.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,9 @@ funcs:
extendedness:
functor: Column
args: base_ClassificationExtendedness_value
sizeExtendedness:
functor: Column
args: base_ClassificationSizeExtendedness_value
flags:
- base_LocalPhotoCalib
- base_LocalPhotoCalib_flag
Expand Down Expand Up @@ -350,6 +353,7 @@ flags:
- base_CircularApertureFlux_50_0_instFlux
- base_CircularApertureFlux_50_0_instFluxErr
- base_ClassificationExtendedness_flag
- base_ClassificationSizeExtendedness_flag
- base_FootprintArea_value
- base_Jacobian_flag
- base_Jacobian_value
Expand Down Expand Up @@ -430,6 +434,7 @@ flag_rename_rules:
- ['base_Local', 'local']
- ['base_PixelFlags_flag', 'pixelFlags']
- ['base_ClassificationE', 'e']
- ['base_ClassificationS', 's']
- ['base_SdssCentroid', 'centroid']
- ['base_Variance', 'variance']
- ['base_Psf', 'psf']
Expand Down
1 change: 1 addition & 0 deletions tests/test_isolatedStarAssociation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def _make_simdata(self,
('apFlux_12_0_instFluxErr', 'f4'),
('apFlux_12_0_instFlux_flag', '?'),
('extendedness', 'f4'),
('sizeExtendedness', 'f4'),
arunkannawadi marked this conversation as resolved.
Show resolved Hide resolved
('detect_isPrimary', bool),
('visit', 'i4'),
('detector', 'i4'),
Expand Down