New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-4037: Require non-empty doc string for config parameters #793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be unrelated format changes as well. Can you split them into its own commit?
@@ -352,5 +356,5 @@ def makeInitialPsf(self, exposure, fwhmPix=None): | |||
model = self.config.initialPsf.model | |||
self.log.info("installInitialPsf fwhm=%s pixels; size=%s pixels", fwhmPix, size) | |||
psfCls = getattr(measAlg, model + "Psf") | |||
psf = psfCls(size, size, fwhmPix/(2.0*num.sqrt(2*num.log(2.0)))) | |||
psf = psfCls(size, size, fwhmPix / (2.0 * num.sqrt(2 * num.log(2.0)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't yet run black
on pipe_tasks so tend to shy away from formatting commits such as this one which conform to the non-black style guide.
@@ -352,5 +356,5 @@ def makeInitialPsf(self, exposure, fwhmPix=None): | |||
model = self.config.initialPsf.model | |||
self.log.info("installInitialPsf fwhm=%s pixels; size=%s pixels", fwhmPix, size) | |||
psfCls = getattr(measAlg, model + "Psf") | |||
psf = psfCls(size, size, fwhmPix/(2.0*num.sqrt(2*num.log(2.0)))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct as is, and should not be reformatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have undone the formatting alteration for this particular line.
e54eb86
to
8b4e997
Compare
8b4e997
to
ffd9b03
Compare
No description provided.