Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38619: Fix errors in fit_coadd_* tasks #798

Merged
merged 2 commits into from
Jul 13, 2023
Merged

DM-38619: Fix errors in fit_coadd_* tasks #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8fb542
Fix id_generator/idGenerator typo
taranu Jun 12, 2023
0f8b162
Add band to CoaddPsfFitConnections dimensions
taranu Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/pipe/tasks/fit_coadd_multiband.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def __init__(self, initInputs, **kwargs):

def runQuantum(self, butlerQC, inputRefs, outputRefs):
inputs = butlerQC.get(inputRefs)
id_tp = self.config.id_generator.apply(butlerQC.quantum.dataId).catalog_id
id_tp = self.config.idGenerator.apply(butlerQC.quantum.dataId).catalog_id
# This is a roundabout way of ensuring all inputs get sorted and matched
input_refs_objs = [(getattr(inputRefs, key), inputs[key])
for key in ("cats_meas", "coadds", "models_psf")]
Expand Down
4 changes: 2 additions & 2 deletions python/lsst/pipe/tasks/fit_coadd_psf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def get_psf_image(self, source):

class CoaddPsfFitConnections(
pipeBase.PipelineTaskConnections,
dimensions=("tract", "patch", "skymap"),
dimensions=("tract", "patch", "band", "skymap"),
defaultTemplates=CoaddPsfFitBaseTemplates,
):
coadd = cT.Input(
Expand Down Expand Up @@ -158,7 +158,7 @@ def __init__(self, initInputs, **kwargs):

def runQuantum(self, butlerQC, inputRefs, outputRefs):
inputs = butlerQC.get(inputRefs)
id_tp = self.config.id_generator.apply(butlerQC.quantum.dataId).catalog_id
id_tp = self.config.idGenerator.apply(butlerQC.quantum.dataId).catalog_id
dataId = inputRefs.cat_meas.dataId
for dataRef in (inputRefs.coadd,):
if dataRef.dataId != dataId:
Expand Down