pipe_tasks tickets/DM-2191, review 2 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you need a bin/ script for coadd measurement as well. |
| """ | ||
| ConfigClass = TransformConfig | ||
| _DefaultName = "transform" | ||
|
|
||
| def __init__(self, measConfig, pluginRegistry, inputSchema, *args, **kwargs): | ||
| def __init__(self, measConfig, pluginRegistry, inputSchema, outputType, *args, **kwargs): |
There was a problem hiding this comment.
You can actually get the PluginRegistry from measConfig: measConfig.plugins.registry, so it doesn't need to be a separate argument.
Also, can't comment on a few lines below, since it's not a change, but "measurments" is a typo.
There was a problem hiding this comment.
I did not realise this -- thanks. It makes the code significantly simpler. Great!
Rather than hard-coding the use of 'src', we provide a function that enables users to build their own tranformation tasks for arbitrary source type names. Note that we can't simply set the source type through configuration, as configuration is persisted and (broadly) immutable, whereas we may want to transform multiple different source types in the same repository.
This is a nice simplification to the logic, and was (in fact) possible all along. Thanks to Jim Bosch for pointing it out.
jdswinbank
force-pushed
the
tickets/DM-2191
branch
from
9e17cba
to
c98b0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fresh PR for a new review after John's refactoring.